Skip to content

cbind on null.dt to non-null.dt now works, closes #3445#3446

Merged
mattdowle merged 3 commits intomasterfrom
cbind-nulldt
Mar 25, 2019
Merged

cbind on null.dt to non-null.dt now works, closes #3445#3446
mattdowle merged 3 commits intomasterfrom
cbind-nulldt

Conversation

@jangorecki
Copy link
Copy Markdown
Member

closes #3445

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 7, 2019

Codecov Report

Merging #3446 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3446      +/-   ##
==========================================
+ Coverage   95.13%   95.14%   +<.01%     
==========================================
  Files          65       65              
  Lines       12303    12307       +4     
==========================================
+ Hits        11705    11709       +4     
  Misses        598      598
Impacted Files Coverage Δ
R/utils.R 91.66% <100%> (+0.17%) ⬆️
R/data.table.R 97.48% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 676c9b2...8fbab9f. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 7, 2019

Codecov Report

Merging #3446 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3446      +/-   ##
==========================================
+ Coverage   96.14%   96.14%   +<.01%     
==========================================
  Files          65       65              
  Lines       12193    12194       +1     
==========================================
+ Hits        11723    11724       +1     
  Misses        470      470
Impacted Files Coverage Δ
R/utils.R 91.48% <ø> (ø) ⬆️
R/data.table.R 97.53% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f25b7ae...f234fe8. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.2 milestone Mar 25, 2019
@mattdowle mattdowle merged commit 62e5c52 into master Mar 25, 2019
@mattdowle mattdowle deleted the cbind-nulldt branch March 25, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cbind of zero-row data.table with empty data.table messes up columns

2 participants