Skip to content

Gforce first last, head tail, coverage#3463

Merged
mattdowle merged 9 commits intomasterfrom
gforce-first-last
Apr 1, 2019
Merged

Gforce first last, head tail, coverage#3463
mattdowle merged 9 commits intomasterfrom
gforce-first-last

Conversation

@jangorecki
Copy link
Copy Markdown
Member

@jangorecki jangorecki commented Mar 17, 2019

closes #2030
closes #3462

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2019

Codecov Report

Merging #3463 into master will decrease coverage by 0.03%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3463      +/-   ##
==========================================
- Coverage   95.17%   95.14%   -0.04%     
==========================================
  Files          65       65              
  Lines       12298    12321      +23     
==========================================
+ Hits        11705    11723      +18     
- Misses        593      598       +5
Impacted Files Coverage Δ
R/data.table.R 97.53% <100%> (+0.05%) ⬆️
src/gsumm.c 90.21% <66.66%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a355cf...f0a0a94. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2019

Codecov Report

Merging #3463 into master will increase coverage by 0.46%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3463      +/-   ##
==========================================
+ Coverage   96.15%   96.62%   +0.46%     
==========================================
  Files          65       65              
  Lines       12229    12250      +21     
==========================================
+ Hits        11759    11836      +77     
+ Misses        470      414      -56
Impacted Files Coverage Δ
src/gsumm.c 96.73% <100%> (+6.04%) ⬆️
R/data.table.R 97.64% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025a911...9483522. Read the comment docs.

@jangorecki jangorecki changed the title Gforce first last Gforce first last, coverage Mar 18, 2019
@jangorecki jangorecki changed the title Gforce first last, coverage Gforce first last, head tail, coverage Mar 18, 2019
@mattdowle mattdowle added this to the 1.12.4 milestone Apr 1, 2019
@mattdowle mattdowle merged commit 58c3b27 into master Apr 1, 2019
@mattdowle mattdowle deleted the gforce-first-last branch April 1, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ghead argument "n" is missing, with no default gfirst(.SD) throws an error about not using head(.SD, n), but the latter works

2 participants