Skip to content

null column#3480

Merged
mattdowle merged 2 commits intomasterfrom
nullcolumn
Mar 28, 2019
Merged

null column#3480
mattdowle merged 2 commits intomasterfrom
nullcolumn

Conversation

@mattdowle
Copy link
Copy Markdown
Member

@mattdowle mattdowle commented Mar 28, 2019

data.table() skips NULL rather than error; surprise was than NCOL(NULL)==1 not 0
NULL columns can be created again; postponed to 1.12.4 so notice can be given to eplusr.
Passes eplusr for #3473

@mattdowle mattdowle added this to the 1.12.2 milestone Mar 28, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2019

Codecov Report

Merging #3480 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3480      +/-   ##
==========================================
- Coverage   96.15%   96.15%   -0.01%     
==========================================
  Files          65       65              
  Lines       12216    12215       -1     
==========================================
- Hits        11746    11745       -1     
  Misses        470      470
Impacted Files Coverage Δ
R/data.table.R 97.53% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e22861...b8c3559. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2019

Codecov Report

Merging #3480 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3480      +/-   ##
==========================================
- Coverage   96.15%   96.15%   -0.01%     
==========================================
  Files          65       65              
  Lines       12216    12215       -1     
==========================================
- Hits        11746    11745       -1     
  Misses        470      470
Impacted Files Coverage Δ
R/data.table.R 97.53% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e22861...b8c3559. Read the comment docs.

@mattdowle mattdowle merged commit fed1d62 into master Mar 28, 2019
@mattdowle mattdowle mentioned this pull request Mar 28, 2019
3 tasks
@mattdowle mattdowle deleted the nullcolumn branch March 28, 2019 22:53
sritchie73 added a commit that referenced this pull request Jan 22, 2020
@sritchie73 sritchie73 mentioned this pull request Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant