empty argument in j output caught early & stopped#3510
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3510 +/- ##
==========================================
+ Coverage 96.68% 96.68% +<.01%
==========================================
Files 65 65
Lines 12280 12281 +1
==========================================
+ Hits 11873 11874 +1
Misses 407 407
Continue to review full report at Codecov.
|
Member
|
Great. For completeness, done : 8eb3bf4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3507 Given that some other languages support trailing commas, e.g. Python:
It might be worth considering whether to support that here by simply dropping that element of
jsub(which would break from base R).Probably coders should be held to picking their commas to match the language -- in R, it's better to use leading commas rather than trailing (for the record, this practice greatly facilitates including/dropping fields in exploratory work, since lines can be commented/uncommented without breaking syntax)