Skip to content

empty argument in j output caught early & stopped#3510

Merged
mattdowle merged 2 commits intomasterfrom
empty_list_error
Apr 16, 2019
Merged

empty argument in j output caught early & stopped#3510
mattdowle merged 2 commits intomasterfrom
empty_list_error

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

@MichaelChirico MichaelChirico commented Apr 16, 2019

Closes #3507 Given that some other languages support trailing commas, e.g. Python:

python3
$ x = [1, 2, ]
$ x
# [1, 2]

It might be worth considering whether to support that here by simply dropping that element of jsub (which would break from base R).

Probably coders should be held to picking their commas to match the language -- in R, it's better to use leading commas rather than trailing (for the record, this practice greatly facilitates including/dropping fields in exploratory work, since lines can be commented/uncommented without breaking syntax)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2019

Codecov Report

Merging #3510 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3510      +/-   ##
==========================================
+ Coverage   96.68%   96.68%   +<.01%     
==========================================
  Files          65       65              
  Lines       12280    12281       +1     
==========================================
+ Hits        11873    11874       +1     
  Misses        407      407
Impacted Files Coverage Δ
R/data.table.R 97.64% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f53b27...960d0c5. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.4 milestone Apr 16, 2019
@mattdowle mattdowle changed the title Closes #3507 -- empty argument in j output caught early & stopped empty argument in j output caught early & stopped Apr 16, 2019
@mattdowle mattdowle merged commit 66166b3 into master Apr 16, 2019
@mattdowle mattdowle deleted the empty_list_error branch April 17, 2019 05:15
@mattdowle
Copy link
Copy Markdown
Member

Great. For completeness, done : 8eb3bf4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Improve error message in case of omitted aggreation

2 participants