between verbose, POSIXct support, RHS dot-alias, int64 support#3518
Merged
between verbose, POSIXct support, RHS dot-alias, int64 support#3518
between verbose, POSIXct support, RHS dot-alias, int64 support#3518Conversation
Codecov Report
@@ Coverage Diff @@
## master #3518 +/- ##
==========================================
+ Coverage 97.43% 97.45% +0.01%
==========================================
Files 66 66
Lines 12708 12801 +93
==========================================
+ Hits 12382 12475 +93
Misses 326 326
Continue to review full report at Codecov.
|
jangorecki
changed the title
between verbose, POSIXct supportbetween verbose, POSIXct support, RHS dot-alias
added 2 commits
April 23, 2019 18:15
jangorecki
commented
Apr 23, 2019
mattdowle
requested changes
Apr 27, 2019
Member
mattdowle
left a comment
mattdowle
left a comment
There was a problem hiding this comment.
Looks good. I made the verbose changes. Just these points to clear up.
jangorecki
changed the title
between verbose, POSIXct support, RHS dot-aliasbetween verbose, POSIXct support, RHS dot-alias
jangorecki
changed the title
between verbose, POSIXct support, RHS dot-aliasbetween verbose, POSIXct support, RHS dot-alias
jangorecki
changed the title
between verbose, POSIXct support, RHS dot-aliasbetween verbose, POSIXct support, RHS dot-alias
Member
Author
|
still adding int64 support, and better coercion for numeric #3517 |
jangorecki
commented
May 1, 2019
jangorecki
commented
May 1, 2019
jangorecki
changed the title
between verbose, POSIXct support, RHS dot-aliasbetween verbose, POSIXct support, RHS dot-alias, int64 support
mattdowle
approved these changes
May 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3516
closes #3519
closes #2315
closes #3517