Skip to content

fread quote="" when last line too short and fill=TRUE#3524

Merged
mattdowle merged 2 commits intomasterfrom
noquote
Apr 25, 2019
Merged

fread quote="" when last line too short and fill=TRUE#3524
mattdowle merged 2 commits intomasterfrom
noquote

Conversation

@mattdowle
Copy link
Copy Markdown
Member

Crash when last line is too short and filled with fill=TRUE, and quote="" (ignore quoting) too. The final \0 at eof was being treated as a quote.
Reported by Jiucang Hao on email so there is no issue.

@mattdowle mattdowle added this to the 1.12.4 milestone Apr 25, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 25, 2019

Codecov Report

Merging #3524 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3524      +/-   ##
==========================================
+ Coverage      97%   97.01%   +<.01%     
==========================================
  Files          66       66              
  Lines       12474    12475       +1     
==========================================
+ Hits        12101    12102       +1     
  Misses        373      373
Impacted Files Coverage Δ
src/fread.c 98.49% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83628ca...c1d15c5. Read the comment docs.

@mattdowle mattdowle merged commit b600b75 into master Apr 25, 2019
@mattdowle mattdowle deleted the noquote branch April 25, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant