Skip to content

Closes #2617 -- overhaul dcast man page#3542

Merged
mattdowle merged 1 commit intomasterfrom
dcast_type_fill_doc
May 10, 2019
Merged

Closes #2617 -- overhaul dcast man page#3542
mattdowle merged 1 commit intomasterfrom
dcast_type_fill_doc

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

#2617

Went ahead and axed all the NEW decorations around 4-year-old features:

2659496

25a74df

Generally just overhauled a lot of the wording which frames dcast.data.table as very closely related to reshape2 but I think it's very much its own thing by now... also reshape2 is dead:

reshape2 is retired

It may be worth deleting a benchmark vs. an obsolescent package as well? Updating with a comparison to tidyr?

@MichaelChirico MichaelChirico force-pushed the dcast_type_fill_doc branch from cfe41bb to 266e2c9 Compare May 4, 2019 17:12
@codecov
Copy link
Copy Markdown

codecov bot commented May 4, 2019

Codecov Report

Merging #3542 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3542   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          66       66           
  Lines       12647    12647           
=======================================
  Hits        12290    12290           
  Misses        357      357

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7810b22...266e2c9. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov bot commented May 4, 2019

Codecov Report

Merging #3542 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3542   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          66       66           
  Lines       12647    12647           
=======================================
  Hits        12290    12290           
  Misses        357      357

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7810b22...266e2c9. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.4 milestone May 10, 2019
@mattdowle mattdowle merged commit bc17059 into master May 10, 2019
@mattdowle mattdowle deleted the dcast_type_fill_doc branch May 10, 2019 23:34
@eddelbuettel
Copy link
Copy Markdown
Contributor

@MichaelChirico @mattdowle Quick thanks for that -- I was reading ?dcast again today in the release version; glad to see this will get refreshed. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants