Edge case of induced printing from source()#3544
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3544 +/- ##
==========================================
+ Coverage 97.17% 97.17% +<.01%
==========================================
Files 66 66
Lines 12647 12649 +2
==========================================
+ Hits 12290 12292 +2
Misses 357 357
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3544 +/- ##
==========================================
+ Coverage 97.43% 97.43% +<.01%
==========================================
Files 66 66
Lines 12705 12707 +2
==========================================
+ Hits 12379 12381 +2
Misses 326 326
Continue to review full report at Codecov.
|
mattdowle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2369
Solution feels a bit hacky/I'm not 100% sure why it works, but tests are passing... should be good enough for an issue that doesn't seem to come up much.