Skip to content

More helpful messaging after readRDS() + assignment#3545

Merged
mattdowle merged 3 commits intomasterfrom
alloc_col_describe_copy
May 12, 2019
Merged

More helpful messaging after readRDS() + assignment#3545
mattdowle merged 3 commits intomasterfrom
alloc_col_describe_copy

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

@MichaelChirico MichaelChirico commented May 5, 2019

Closes #1729

Feels slightly less natural to suppress what was the first of the duplicate verbose messages, but I didn't see a simple way to only suppress the second one.

@codecov
Copy link
Copy Markdown

codecov bot commented May 5, 2019

Codecov Report

Merging #3545 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3545      +/-   ##
==========================================
+ Coverage   97.17%   97.17%   +<.01%     
==========================================
  Files          66       66              
  Lines       12647    12648       +1     
==========================================
+ Hits        12290    12291       +1     
  Misses        357      357
Impacted Files Coverage Δ
src/assign.c 100% <100%> (ø) ⬆️
R/data.table.R 97.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7810b22...22768b9. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented May 5, 2019

Codecov Report

Merging #3545 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3545      +/-   ##
==========================================
+ Coverage   97.43%   97.43%   +<.01%     
==========================================
  Files          66       66              
  Lines       12707    12708       +1     
==========================================
+ Hits        12381    12382       +1     
  Misses        326      326
Impacted Files Coverage Δ
src/assign.c 100% <100%> (ø) ⬆️
R/data.table.R 97.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7438e5c...558aff4. Read the comment docs.

@mattdowle mattdowle changed the title Closes #1729 -- more helpful messaging after readRDS() + assignment More helpful messaging after readRDS() + assignment May 11, 2019
@mattdowle mattdowle added this to the 1.12.4 milestone May 11, 2019
@mattdowle mattdowle merged commit 7ce2a04 into master May 12, 2019
@MichaelChirico MichaelChirico deleted the alloc_col_describe_copy branch May 12, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

:= changes address of a data table

2 participants