Skip to content

group by NULL and zero rows DT now consistent#3561

Merged
mattdowle merged 1 commit intomasterfrom
zero-row-by-null
May 14, 2019
Merged

group by NULL and zero rows DT now consistent#3561
mattdowle merged 1 commit intomasterfrom
zero-row-by-null

Conversation

@jangorecki
Copy link
Copy Markdown
Member

closes #3530

@codecov
Copy link
Copy Markdown

codecov bot commented May 14, 2019

Codecov Report

Merging #3561 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3561      +/-   ##
==========================================
+ Coverage   97.45%   97.45%   +<.01%     
==========================================
  Files          66       66              
  Lines       12801    12806       +5     
==========================================
+ Hits        12475    12480       +5     
  Misses        326      326
Impacted Files Coverage Δ
R/data.table.R 97.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 572b6e4...0020358. Read the comment docs.

@mattdowle mattdowle changed the title group by NULL and zero rows DT now consistent, closes #3530 group by NULL and zero rows DT now consistent May 14, 2019
@mattdowle mattdowle added this to the 1.12.4 milestone May 14, 2019
@mattdowle mattdowle merged commit fc645b8 into master May 14, 2019
@mattdowle mattdowle deleted the zero-row-by-null branch May 14, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow by = NULL on zero-row data.table

2 participants