Skip to content

retain unused levels from zero-row data.table in rbindlist#3586

Merged
mattdowle merged 2 commits intomasterfrom
rbind_zero_factors
May 23, 2019
Merged

retain unused levels from zero-row data.table in rbindlist#3586
mattdowle merged 2 commits intomasterfrom
rbind_zero_factors

Conversation

@mattdowle
Copy link
Copy Markdown
Member

Closes #3508

@mattdowle mattdowle added this to the 1.12.4 milestone May 23, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented May 23, 2019

Codecov Report

Merging #3586 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3586      +/-   ##
==========================================
+ Coverage   97.63%   97.63%   +<.01%     
==========================================
  Files          66       66              
  Lines       12701    12702       +1     
==========================================
+ Hits        12400    12401       +1     
  Misses        301      301
Impacted Files Coverage Δ
src/rbindlist.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7d5df4...8b13f3e. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented May 23, 2019

Codecov Report

Merging #3586 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3586      +/-   ##
==========================================
+ Coverage   97.63%   97.63%   +<.01%     
==========================================
  Files          66       66              
  Lines       12701    12702       +1     
==========================================
+ Hits        12400    12401       +1     
  Misses        301      301
Impacted Files Coverage Δ
src/rbindlist.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7d5df4...69f4daf. Read the comment docs.

@mattdowle mattdowle merged commit dd236a0 into master May 23, 2019
@mattdowle mattdowle deleted the rbind_zero_factors branch May 23, 2019 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rbind and rbindlist drop factor levels when data.table has zero rows

1 participant