Skip to content

Follow-up to #3572#3593

Merged
mattdowle merged 1 commit intomasterfrom
sd_vignette
May 24, 2019
Merged

Follow-up to #3572#3593
mattdowle merged 1 commit intomasterfrom
sd_vignette

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

Jan had some extra feedback on #3572.

Regarding the <code> block in the header, I think that's just a GitLab issue. title YAML field is supposed to go into the browser tab, I thought... I guess GitLab is not using MultiMarkdown, or something like that? The datatable-intro vignette has the same issue on Gitlab but it renders correctly on CRAN, so ignoring that part.

@codecov
Copy link
Copy Markdown

codecov bot commented May 24, 2019

Codecov Report

Merging #3593 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3593   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files          66       66           
  Lines       12721    12721           
=======================================
  Hits        12420    12420           
  Misses        301      301

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df28194...1cbf466. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov bot commented May 24, 2019

Codecov Report

Merging #3593 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3593   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files          66       66           
  Lines       12721    12721           
=======================================
  Hits        12420    12420           
  Misses        301      301

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df28194...1cbf466. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.4 milestone May 24, 2019
@mattdowle mattdowle merged commit 3ade508 into master May 24, 2019
@mattdowle mattdowle deleted the sd_vignette branch May 24, 2019 22:37
@jangorecki
Copy link
Copy Markdown
Member

It is not strictly related to GitLab, I am getting same <code> after rendering vignette locally on my laptop. I think CRAN uses some pandoc configuration that handles that better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants