Skip to content

rbindlist ordered factor with levels containing NA#3603

Merged
mattdowle merged 1 commit intomasterfrom
rbind_ordered_na_level
May 26, 2019
Merged

rbindlist ordered factor with levels containing NA#3603
mattdowle merged 1 commit intomasterfrom
rbind_ordered_na_level

Conversation

@mattdowle
Copy link
Copy Markdown
Member

Closes #3601

@mattdowle mattdowle added this to the 1.12.4 milestone May 26, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented May 26, 2019

Codecov Report

Merging #3603 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3603      +/-   ##
==========================================
- Coverage   97.73%   97.73%   -0.01%     
==========================================
  Files          66       66              
  Lines       12910    12909       -1     
==========================================
- Hits        12617    12616       -1     
  Misses        293      293
Impacted Files Coverage Δ
src/rbindlist.c 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21ac65...11e259c. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov bot commented May 26, 2019

Codecov Report

Merging #3603 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3603      +/-   ##
==========================================
- Coverage   97.73%   97.73%   -0.01%     
==========================================
  Files          66       66              
  Lines       12910    12909       -1     
==========================================
- Hits        12617    12616       -1     
  Misses        293      293
Impacted Files Coverage Δ
src/rbindlist.c 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21ac65...11e259c. Read the comment docs.

@mattdowle mattdowle merged commit 1b12c69 into master May 26, 2019
@mattdowle mattdowle deleted the rbind_ordered_na_level branch May 26, 2019 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rbindlist segfault when a table includes an 'ordered factor' with NA in its levels

1 participant