Skip to content

forder on Date suggest integer in verbose mode#3624

Merged
mattdowle merged 3 commits intomasterfrom
forder-date
Jul 20, 2019
Merged

forder on Date suggest integer in verbose mode#3624
mattdowle merged 3 commits intomasterfrom
forder-date

Conversation

@jangorecki
Copy link
Copy Markdown
Member

@jangorecki jangorecki commented Jun 3, 2019

Closes #1738
somehow it fails bmerge test with typeof INT != DATE, although I am not able to reproduce update by reference of date column

set.seed(1L)
dt = data.table(d=sample(seq(as.Date("2015-01-01"), as.Date("2015-12-31"), by="days"), 1e7, TRUE))
o = forder(dt)
str(dt)
#Classes ‘data.table’ and 'data.frame':	10000000 obs. of  1 variable:
# $ d: Date, format: "2015-04-07" "2015-05-16" ...
# - attr(*, ".internal.selfref")=<externalptr> 

@jangorecki jangorecki added the WIP label Jun 3, 2019
@mattdowle mattdowle added this to the 1.12.4 milestone Jul 20, 2019
@mattdowle mattdowle changed the title forder on Date column coerce to Integer for speed forder on Date suggest integer in verbose mode Jul 20, 2019
…r feedback, and added comments to forder.c on how to do the automatic coerce in future
@mattdowle mattdowle removed the WIP label Jul 20, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 20, 2019

Codecov Report

Merging #3624 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3624      +/-   ##
==========================================
+ Coverage   98.45%   98.45%   +<.01%     
==========================================
  Files          69       69              
  Lines       13284    13287       +3     
==========================================
+ Hits        13079    13082       +3     
  Misses        205      205
Impacted Files Coverage Δ
src/forder.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5c0bed...692a188. Read the comment docs.

@mattdowle mattdowle merged commit 5ca3366 into master Jul 20, 2019
@mattdowle mattdowle deleted the forder-date branch July 20, 2019 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

forder should detect and switch to integer type on columns that aren't really double

2 participants