forder on Date suggest integer in verbose mode#3624
Merged
Conversation
…r feedback, and added comments to forder.c on how to do the automatic coerce in future
Codecov Report
@@ Coverage Diff @@
## master #3624 +/- ##
==========================================
+ Coverage 98.45% 98.45% +<.01%
==========================================
Files 69 69
Lines 13284 13287 +3
==========================================
+ Hits 13079 13082 +3
Misses 205 205
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1738
somehow it fails
bmergetest withtypeof INT != DATE, although I am not able to reproduce update by reference of date column