Skip to content

dt array method when some dimnames are NULL#3637

Merged
mattdowle merged 2 commits intomasterfrom
as.dt.array.null.dimnames
Jun 12, 2019
Merged

dt array method when some dimnames are NULL#3637
mattdowle merged 2 commits intomasterfrom
as.dt.array.null.dimnames

Conversation

@jangorecki
Copy link
Copy Markdown
Member

closes #3636

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 10, 2019

Codecov Report

Merging #3637 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3637      +/-   ##
=========================================
+ Coverage    98.2%   98.2%   +<.01%     
=========================================
  Files          66      66              
  Lines       12980   12986       +6     
=========================================
+ Hits        12747   12753       +6     
  Misses        233     233
Impacted Files Coverage Δ
R/as.data.table.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efeee7c...f1aaa29. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.4 milestone Jun 12, 2019
@mattdowle mattdowle changed the title dt array method more smart, closes #3636 dt array method when some dimnames are NULL Jun 12, 2019
@mattdowle mattdowle merged commit be1fae5 into master Jun 12, 2019
@mattdowle mattdowle deleted the as.dt.array.null.dimnames branch June 12, 2019 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

as.data.table array method should handle some NULL dimnames

2 participants