Skip to content

test.data.table was sensitive to datatable.integer64 option#3684

Merged
mattdowle merged 3 commits intomasterfrom
int64_tests
Jul 15, 2019
Merged

test.data.table was sensitive to datatable.integer64 option#3684
mattdowle merged 3 commits intomasterfrom
int64_tests

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

@MichaelChirico MichaelChirico commented Jul 7, 2019

Closes #3683

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 7, 2019

Codecov Report

Merging #3684 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3684   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files          69       69           
  Lines       13088    13088           
=======================================
  Hits        12860    12860           
  Misses        228      228

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb0d0b...8ab9bea. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 7, 2019

Codecov Report

Merging #3684 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3684   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files          69       69           
  Lines       13084    13084           
=======================================
  Hits        12856    12856           
  Misses        228      228

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 383a741...ab3ef1c. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.4 milestone Jul 15, 2019
@mattdowle mattdowle changed the title Closes #3683 -- test.data.table handles pre-declared datatable.intege… test.data.table was sensitive to datatable.integer64 option Jul 15, 2019
@mattdowle mattdowle merged commit 5d931ae into master Jul 15, 2019
@mattdowle mattdowle deleted the int64_tests branch July 15, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setting options(datatable.integer64="character") for data.table makes error in test.data.table()

2 participants