setkey works on tables with complex columns

[MichaelChirico]

Closes #1444
Closes #3704

[codecov]

Codecov Report

Merging #3688 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #3688      +/-   ##
=========================================
+ Coverage   98.29%   98.3%   +0.01%     
=========================================
  Files          69      69              
  Lines       13285   13267      -18     
=========================================
- Hits        13058   13042      -16     
+ Misses        227     225       -2

Impacted Files	Coverage Δ
src/init.c	100% <ø> (ø)	⬆️
R/setkey.R	98.69% <ø> (-0.01%)	⬇️
src/reorder.c	100% <100%> (+2.53%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0a218...14195c3. Read the comment docs.

[MichaelChirico]

raw columns continue to fail:

DT = data.table(ID = 2:1, r = as.raw(0:1))
setkey(DT, ID)

Error in setkeyv(x, cols, verbose = verbose, physical = physical) :
Item 2 of list is type 'raw' which isn't yet supported (SIZEOF=1)

Should we try and add that to this PR as well?

Ditto expression:

DT = data.table(ID = 2:1, x = expression(1, 2))
setkey(DT, ID)

Error in setkeyv(x, cols, verbose = verbose, physical = physical) :
Item 2 of list is type 'expression' which isn't yet supported (SIZEOF=0)

(not sure how SIZEOF can be 0 🤔

If not, then we can at least use these for codecov of the 4/8/16 error

[MichaelChirico]

Trying to do coverage and came across this function: setrev

I don't see it used anywhere and it's not exported... shall we delete it? Otherwise we should file an issue to have it exported.

grep to show it's unused:

grep -r "setrev" . | grep -v "Rproj" | grep -v "tests/tests" | grep -v "Binary"
./R/setkey.R:setrev = function(x) .Call(Csetrev, x)
./src/init.c:SEXP setrev();
./src/init.c:{"Csetrev", (DL_FUNC) &setrev, -1},
./src/reorder.c:SEXP setrev(SEXP x) {

[MichaelChirico]

Have merged what's done here into #3701 because the reorder work was needed to get setkey working there. Closing this & filing the above comment as an issue.

[MichaelChirico]

reopening to help reduce the size&complexity of #3701