add default to all switch statements in src; coverage#3720
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3720 +/- ##
=========================================
+ Coverage 98.45% 98.8% +0.34%
=========================================
Files 69 69
Lines 13287 13285 -2
=========================================
+ Hits 13082 13126 +44
+ Misses 205 159 -46
Continue to review full report at Codecov.
|
MichaelChirico
changed the title
MichaelChirico
force-pushed
the
switch_default
branch
from
dd3efdf to
256847c
Compare
add coverage tests of touched files fix test vestigial msg
MichaelChirico
force-pushed
the
switch_default
branch
from
256847c to
2070c85
Compare
mattdowle
reviewed
Jul 22, 2019
mattdowle
requested changes
Jul 22, 2019
Member
mattdowle
left a comment
mattdowle
left a comment
There was a problem hiding this comment.
LGTM. Just minor changes please.
Member
Author
|
@mattdowle done with
https://github.com/Rdatatable/data.table/pull/3720/files?w=1 |
Member
|
great. no worries - I did the whitespace as I was in diff anyway |
mattdowle
approved these changes
Jul 23, 2019
Member
|
Wow - that's an increase of 0.34% coverage! That's a pretty big bang for that buck of relatively few lines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by: #3692 (comment)
Ran:
And found the files here with
default-less switches. Added internal errors for them+nocov'd, except in the one case where it was actually reasonable to reach there. Had to make a small edit towriteNAto make it even easier to do so (even without thatfill=expression(1)would get there).Mostly, the
default-less switches areswitch(enum)so it should be impossible in the current code to reach. These errors guard against editing theenums' valid values in the future & neglecting to cover all the bases in testing new functionality.