unlock shallow copy of .SD when needed in joins in j#3774
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3774 +/- ##
==========================================
+ Coverage 99.41% 99.41% +<.01%
==========================================
Files 71 71
Lines 13225 13241 +16
==========================================
+ Hits 13148 13164 +16
Misses 77 77
Continue to review full report at Codecov.
|
jangorecki
reviewed
Aug 20, 2019
Member
jangorecki
left a comment
jangorecki
left a comment
There was a problem hiding this comment.
no idea about setattr in shallow copy
Member
|
We should definitely get this in 1.12.4 to clean up new vignette. @MichaelChirico |
Member
Author
|
it's ready to go w your approval 👍 |
mattdowle
changed the title
MichaelChirico
commented
Aug 28, 2019
This was referenced Sep 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1926
@franknarf1 I went through a few of the examples you posted and the fix here seems to work, it would be great if you could try and stress test it a bit anyway to make sure all the bases are covered 🙇
@jangorecki / @mattdowle do we need to re-set the locked attr
on.exit()for the shallow copies as well?