Skip to content

simplify hour() etc for ITime#3782

Merged
mattdowle merged 4 commits intomasterfrom
fast_itime
Aug 30, 2019
Merged

simplify hour() etc for ITime#3782
mattdowle merged 4 commits intomasterfrom
fast_itime

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

@MichaelChirico MichaelChirico commented Aug 20, 2019

Closes #3158

Will need to be re-worked after #3781

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 20, 2019

Codecov Report

Merging #3782 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3782   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files          71       71           
  Lines       13245    13245           
=======================================
  Hits        13168    13168           
  Misses         77       77
Impacted Files Coverage Δ
R/IDateTime.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5fafbc...e346893. Read the comment docs.

Comment thread R/IDateTime.R Outdated
Comment thread R/IDateTime.R Outdated
@mattdowle mattdowle changed the title Closes #3158 -- simplify hour() etc for ITime simplify hour() etc for ITime Aug 30, 2019
@mattdowle mattdowle added this to the 1.12.4 milestone Aug 30, 2019
@Rdatatable Rdatatable deleted a comment from codecov bot Aug 30, 2019
@mattdowle mattdowle merged commit 8567b74 into master Aug 30, 2019
@mattdowle mattdowle deleted the fast_itime branch August 30, 2019 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Faster second, minute and hour for objects of class ITime

3 participants