new arg to gsum to allow gmean to ignore overflow warning#3796
Merged
new arg to gsum to allow gmean to ignore overflow warning#3796
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3796 +/- ##
==========================================
+ Coverage 99.41% 99.41% +<.01%
==========================================
Files 71 71
Lines 13246 13247 +1
==========================================
+ Hits 13169 13170 +1
Misses 77 77
Continue to review full report at Codecov.
|
jangorecki
approved these changes
Aug 28, 2019
Member
|
Recommend removing the warning altogether. Can't think of circumstances where it would be necessary or useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #986
Seems to me this is the way to go, the other ways (e.g. rewrite
gmeanwithout usinggsumare pretty prohibitive for kind of edge case)