Conversation
Codecov Report
@@ Coverage Diff @@
## master #3814 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 71 71
Lines 13432 13432
=======================================
Hits 13355 13355
Misses 77 77
Continue to review full report at Codecov.
|
mattdowle
reviewed
Sep 12, 2019
| "' clashed with variable(s) in j. Therefore assigning the entire by-expression as name.\n", sep="") | ||
| } | ||
| else bynames[jj] = tt | ||
| # if user doesn't like this inferred name, user has to use by=list() to name the column |
Member
There was a problem hiding this comment.
For future reference: hide whitespace option in github works well in this case. Otherwise it shows a big block of 20 lines removed and added without any finer detail. With hide-whitespace on the diff reduces dramatically. Further down there was a space after a closing brace which seems to trip up the default view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3156
As mentioned in #3156 (comment), not an ideal solution but I think it'll rock the boat a bit to go too deep for this release. Will file a follow-up to revisit this after 1.12.4