Skip to content

only use lag in shift give.names if mixing signs#3833

Merged
mattdowle merged 1 commit intomasterfrom
shift_regression
Sep 11, 2019
Merged

only use lag in shift give.names if mixing signs#3833
mattdowle merged 1 commit intomasterfrom
shift_regression

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

Closes #3832

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 6, 2019

Codecov Report

Merging #3833 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3833   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          71       71           
  Lines       13408    13408           
=======================================
  Hits        13331    13331           
  Misses         77       77
Impacted Files Coverage Δ
R/shift.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76edf19...7f20a08. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.4 milestone Sep 11, 2019
@mattdowle mattdowle merged commit 8133aeb into master Sep 11, 2019
@mattdowle mattdowle deleted the shift_regression branch September 11, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changes to shift cause backwards naming issues

3 participants