make units explicit on implicit difftime by group#3837
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3837 +/- ##
==========================================
- Coverage 99.42% 99.41% -0.01%
==========================================
Files 71 71
Lines 13408 13415 +7
==========================================
+ Hits 13331 13337 +6
- Misses 77 78 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3837 +/- ##
==========================================
+ Coverage 99.42% 99.42% +<.01%
==========================================
Files 71 71
Lines 13416 13423 +7
==========================================
+ Hits 13339 13346 +7
Misses 77 77
Continue to review full report at Codecov.
|
jangorecki
approved these changes
Sep 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3694 and #761 (and there are several duplicates already closed as well)
If we think the overhead of the
!inherits(e2, 'POSIXt')-->base::-.POSIXtcase is too high, we could copy-paste the rest of the-.POSIXtbody into our mask...