Skip to content

make units explicit on implicit difftime by group#3837

Merged
mattdowle merged 4 commits intomasterfrom
group_difftime
Sep 11, 2019
Merged

make units explicit on implicit difftime by group#3837
mattdowle merged 4 commits intomasterfrom
group_difftime

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

Closes #3694 and #761 (and there are several duplicates already closed as well)

If we think the overhead of the !inherits(e2, 'POSIXt') --> base::-.POSIXt case is too high, we could copy-paste the rest of the -.POSIXt body into our mask...

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 8, 2019

Codecov Report

Merging #3837 into master will decrease coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3837      +/-   ##
==========================================
- Coverage   99.42%   99.41%   -0.01%     
==========================================
  Files          71       71              
  Lines       13408    13415       +7     
==========================================
+ Hits        13331    13337       +6     
- Misses         77       78       +1
Impacted Files Coverage Δ
R/data.table.R 99.94% <85.71%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76edf19...44d82c2. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 8, 2019

Codecov Report

Merging #3837 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3837      +/-   ##
==========================================
+ Coverage   99.42%   99.42%   +<.01%     
==========================================
  Files          71       71              
  Lines       13416    13423       +7     
==========================================
+ Hits        13339    13346       +7     
  Misses         77       77
Impacted Files Coverage Δ
R/data.table.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50bc98...bfc3372. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.4 milestone Sep 11, 2019
@mattdowle mattdowle merged commit 389a35c into master Sep 11, 2019
@mattdowle mattdowle deleted the group_difftime branch September 11, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

calculating time difference by group might get the units messed up

3 participants