Skip to content

rbindlist segfault when recycling length-1 factors#3894

Merged
mattdowle merged 2 commits intomasterfrom
rbindlist_segfault
Sep 19, 2019
Merged

rbindlist segfault when recycling length-1 factors#3894
mattdowle merged 2 commits intomasterfrom
rbindlist_segfault

Conversation

@mattdowle
Copy link
Copy Markdown
Member

Closes #3662

@mattdowle mattdowle added this to the 1.12.4 milestone Sep 19, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 19, 2019

Codecov Report

Merging #3894 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3894      +/-   ##
==========================================
+ Coverage   99.42%   99.42%   +<.01%     
==========================================
  Files          72       72              
  Lines       13498    13505       +7     
==========================================
+ Hits        13421    13428       +7     
  Misses         77       77
Impacted Files Coverage Δ
src/rbindlist.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcbe74c...767c3ad. Read the comment docs.

@mattdowle mattdowle merged commit 3e71595 into master Sep 19, 2019
@mattdowle mattdowle mentioned this pull request Sep 19, 2019
@mattdowle mattdowle deleted the rbindlist_segfault branch September 19, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rbindlist raises malformed factor

1 participant