Skip to content

compress *.Rraw in release only, not git.#3937

Merged
mattdowle merged 2 commits intomasterfrom
installed_size_note_2
Oct 4, 2019
Merged

compress *.Rraw in release only, not git.#3937
mattdowle merged 2 commits intomasterfrom
installed_size_note_2

Conversation

@mattdowle
Copy link
Copy Markdown
Member

@mattdowle mattdowle commented Oct 4, 2019

Follow up to #3933
Just adds the notes to CRAN_Release.cmd, plus some refinements to test.data.table() find the file with the .Rraw.bz2 extension. But other than that, base::sys.source() already accepts compressed input directly.

The saves another 0.75MB, to add to the saving in #3933 of 0.27MB brings the overall installed size of /inst/tests down from 1.7MB to 0.7MB. Plenty to avoid the 5.1MB breach of 5.0MB. We should be at around 4.0MB now even with a -g bloated .so.

@mattdowle mattdowle added this to the 1.12.5 milestone Oct 4, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 4, 2019

Codecov Report

Merging #3937 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3937      +/-   ##
=========================================
+ Coverage    99.4%   99.4%   +<.01%     
=========================================
  Files          72      72              
  Lines       13642   13644       +2     
=========================================
+ Hits        13561   13563       +2     
  Misses         81      81
Impacted Files Coverage Δ
R/test.data.table.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6e5aa6...4fbaadb. Read the comment docs.

@mattdowle mattdowle merged commit 7127154 into master Oct 4, 2019
@mattdowle mattdowle deleted the installed_size_note_2 branch October 4, 2019 20:42
@mattdowle mattdowle modified the milestones: 1.12.7, 1.12.5 Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant