Avoid frollapply() stack overflows and protect limits#3994
Merged
mattdowle merged 5 commits intoRdatatable:masterfrom Dec 8, 2019
Merged
Avoid frollapply() stack overflows and protect limits#3994mattdowle merged 5 commits intoRdatatable:masterfrom
frollapply() stack overflows and protect limits#3994mattdowle merged 5 commits intoRdatatable:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3994 +/- ##
=========================================
- Coverage 99.4% 99.4% -0.01%
=========================================
Files 72 72
Lines 13652 13650 -2
=========================================
- Hits 13571 13569 -2
Misses 81 81
Continue to review full report at Codecov.
|
Member
|
Thanks for fixes. The second commit is a nice change. I kept all objects pre-allocated to align to the code of other rolling functions, but because roll apply will not run in parallel we can safely override those variables inside the loop. Will add tests. |
Member
|
Tests were added but disabled by default as they require 1.6 GB, 16 GB and 16GB memory. There is no way to tests those failures in a lightweight way. |
jangorecki
approved these changes
Oct 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3993
The following three examples from #3993 now run without issue, no segfaults!
If someone else wants to take over adding tests (if you want them), please go ahead. I'm not familiar with how you all test the package.