Allow C-level calls to forder#4017
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4017 +/- ##
==========================================
+ Coverage 99.41% 99.41% +<.01%
==========================================
Files 72 72
Lines 13904 13905 +1
==========================================
+ Hits 13823 13824 +1
Misses 81 81
Continue to review full report at Codecov.
|
|
@lsilvest this PR by @mattfidler exports one more C function. It didn't have the |
| R_RegisterCCallable("data.table", "CsubsetDT", (DL_FUNC) &subsetDT); | ||
|
|
||
| R_RegisterCCallable("data.table", "subsetDT", (DL_FUNC) &subsetDT); | ||
| R_RegisterCCallable("data.table", "forder", (DL_FUNC) &forder); |
There was a problem hiding this comment.
need to add to ?cdt as well right
|
Needs addition to the news item about subsetDT, and addition to ?cdt, please. I invited you to be project member, @mattfidler. This enabled you to create branches in the main project in future. You'll need to accept the invitation which shows as a button on your GitHub profile or GitHub repository page. Welcome! |
|
Sorry Missed your comment @mattdowle. There is alot of traffic on Thank you for the excellent package. I don't need to be a contributor for this (in my opinion). However CRAN may differ from my opinion (they have in the past). I am fine adding myself as a contributor if I need to. |
|
I also couldn't see a project member email or any buttons; Perhaps the invitation has expired. |
|
@mattfidler are you planning to incorporate the feedback (cdt manual, news file, description file, comment in forder.c)? or you are not interested anymore in completing this PR? |
|
I realized this is still open. I had forgot about this |
Closes #4015
I don't actually think this is a duplicate; It allows calling the underlying C code with evaluating in R, which could be faster.