Skip to content

fwrite gzip on Solaris 10: more tracing#4028

Merged
mattdowle merged 2 commits intomasterfrom
solaris3
Nov 5, 2019
Merged

fwrite gzip on Solaris 10: more tracing#4028
mattdowle merged 2 commits intomasterfrom
solaris3

Conversation

@mattdowle
Copy link
Copy Markdown
Member

@mattdowle mattdowle commented Nov 5, 2019

More follow-up to #3964
I have emailed this tar.gz to Prof Ripley to run on Solaris and send back the output.

  • error message includes both library version and zlib.h version; a mismatch is expected but it isn't supposed to matter if the first digit is the same which is expected.
  • more tracing of inputs and constants in verbose mode, based on reading zlib's source code to see why it is returned Z_STREAM_ERROR. I attempted to trace zlib's internal state too (which causes Z_STREAM_ERROR in several places in zlib's source) but that appears to be hidden from application usage and won't compile.
  • when test() fails with an unexpected error (as is the case on Solaris currently) and it was passed an output= to check, the captured output is now displayed for the log. Currently that output is not being displayed in the CRAN output for this test 1658.421. This may help other tests in general too.

Currently Solaris is the only error on CRAN with the following output:

     Running test id 1658.4
     Running test id 1658.41
     Running test id 1658.421 Test 1658.421 produced 1 errors but expected 0
     Expected:
     Observed: zlib v1.2.11 deflate() returned error -2 with z_stream.msg ''. Please include the full output above in your data.table bug report.
     Running test id 1658.422
     Running test id 1658.423
     Running test id 1658.43 Test 1658.43 ran without errors but failed check that x equals y:
     > x = fread(f1)
     Empty data.table (0 rows and 2 cols): a,b
     [Key= Types=log,log Classes=log,log]
     > y = DT
     a b [Key= Types=int,int Classes=int,int]
     1: 1 1
     2: 1 1
     ---
     199: 2 4
     200: 2 4
     Different number of rows
     Error in fwrite(DT, file = f3 <- tempfile(), compress = "gzip") :
     zlib v1.2.11 deflate() returned error -2 with z_stream.msg ''. Please retry fwrite() with verbose=TRUE and include the full output with your data.table bug report.
     Calls: test.data.table -> sys.source -> eval -> eval -> fwrite
     Execution halted

@mattdowle mattdowle added this to the 1.12.7 milestone Nov 5, 2019
@mattdowle mattdowle changed the title added .h version, more tracing, and included captured output after error fwrite gzip on Solaris 10 further follow up Nov 5, 2019
@mattdowle mattdowle changed the title fwrite gzip on Solaris 10 further follow up fwrite gzip on Solaris 10: more tracing Nov 5, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 5, 2019

Codecov Report

Merging #4028 into master will decrease coverage by 0.01%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4028      +/-   ##
==========================================
- Coverage    99.4%   99.39%   -0.02%     
==========================================
  Files          72       72              
  Lines       13652    13657       +5     
==========================================
+ Hits        13571    13574       +3     
- Misses         81       83       +2
Impacted Files Coverage Δ
src/fwrite.c 97.87% <100%> (ø) ⬆️
R/test.data.table.R 98.72% <33.33%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c7574...1d70177. Read the comment docs.

@mattdowle mattdowle merged commit 1a59477 into master Nov 5, 2019
@mattdowle mattdowle deleted the solaris3 branch November 5, 2019 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant