Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4057 +/- ##
=========================================
+ Coverage 99.4% 99.4% +<.01%
=========================================
Files 72 72
Lines 13673 13674 +1
=========================================
+ Hits 13592 13593 +1
Misses 81 81
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #3802 to pass R 3.1.0
Closes #4048 without bumping
I found a simple way to backport the R 3.2.0 feature without using a switch on version number or feature test. This avoids the complexity of more code and nocov.
Also slightly simplified the logic in data.table.R regarding autonaming to avoid a little bit of overhead, but that wasn't needed to support R 3.1.0.