Skip to content

Idate tz#4088

Merged
mattdowle merged 3 commits intomasterfrom
idate_tz
Dec 14, 2019
Merged

Idate tz#4088
mattdowle merged 3 commits intomasterfrom
idate_tz

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

Closes #4085

Tried using !is.null(tz) && tz %chin% c('UTC', 'GMT'), but I got an error around here:

Running test id 1613.43      Error in as.POSIXlt.POSIXct(x, tz = tz, ...) : invalid 'tz' value

Though apparently this works: as.POSIXlt(.POSIXct(0, tz = NULL)) so I'm not sure what happened. Anyway tz='' is the same as is.null(tz) as near as I can tell.

cc @arunsrinivasan

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 4, 2019

Codecov Report

Merging #4088 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4088   +/-   ##
======================================
  Coverage    99.4%   99.4%           
======================================
  Files          72      72           
  Lines       13685   13685           
======================================
  Hits        13604   13604           
  Misses         81      81
Impacted Files Coverage Δ
R/IDateTime.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afdcdad...04cd7ca. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.9 milestone Dec 14, 2019
@mattdowle mattdowle merged commit d1c1b26 into master Dec 14, 2019
@mattdowle mattdowle deleted the idate_tz branch December 14, 2019 19:46
mattdowle added a commit that referenced this pull request Dec 17, 2019
@jangorecki jangorecki modified the milestones: 1.12.11, 1.12.9 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in as.ITime.POSIXct

3 participants