Skip to content

R 4.0 compatible head-tail tests, closes #4127#4136

Merged
mattdowle merged 2 commits intomasterfrom
head-tail-r4
Dec 31, 2019
Merged

R 4.0 compatible head-tail tests, closes #4127#4136
mattdowle merged 2 commits intomasterfrom
head-tail-r4

Conversation

@jangorecki
Copy link
Copy Markdown
Member

@jangorecki jangorecki commented Dec 24, 2019

closes #4127
I realized it may fail on our R-devel windows machine because it might be not up to date enough to include that change. I upgraded R-devel on our windows machine (2019-12-21 r77613 now), testing this PR on https://gitlab.com/jangorecki/data.table/pipelines/105281430

@jangorecki jangorecki added this to the 1.12.9 milestone Dec 24, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 24, 2019

Codecov Report

Merging #4136 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4136   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files          72       72           
  Lines       13909    13909           
=======================================
  Hits        13828    13828           
  Misses         81       81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f86415...01ab6e1. Read the comment docs.

@jangorecki jangorecki added the WIP label Dec 24, 2019
@jangorecki jangorecki removed the WIP label Dec 24, 2019
@mattdowle mattdowle merged commit ef416d3 into master Dec 31, 2019
@mattdowle mattdowle deleted the head-tail-r4 branch December 31, 2019 02:21
@jangorecki jangorecki modified the milestones: 1.12.11, 1.12.9 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

first-last head-tail different in R 4.0

2 participants