Skip to content

openmp detection follow up #4157

Merged
mattdowle merged 2 commits intomasterfrom
config_bashism
Jan 3, 2020
Merged

openmp detection follow up #4157
mattdowle merged 2 commits intomasterfrom
config_bashism

Conversation

@mattdowle
Copy link
Copy Markdown
Member

Minor follow up to #3984

  • echo=>printf to pass the checkbashism 'unsafe echo with backslash'
$ checkbashisms ./configure
possible bashism in ./configure line 60 (unsafe echo with backslash):
echo "#include <omp.h>\nint main () { return omp_get_num_threads (); }" | ${CC} ${CPPFLAGS} ${PKG_CFLAGS} ${CFLAGS} ${SHLIB_OPENMP_CFLAGS} -E -xc - >/dev/null 2>&1 || R_NO_OPENMP=1;
  • removed the -E too so that this line checks linking too. I tested by making a deliberate typo in the name of the omp_get call. That took much longer to get right than I expected, as the inline comment alludes.

@mattdowle mattdowle added this to the 1.12.9 milestone Jan 2, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 3, 2020

Codecov Report

Merging #4157 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4157   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files          72       72           
  Lines       13911    13911           
=======================================
  Hits        13847    13847           
  Misses         64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a2a02b...a2b8d47. Read the comment docs.

@mattdowle mattdowle merged commit 3d24927 into master Jan 3, 2020
@mattdowle mattdowle deleted the config_bashism branch January 3, 2020 00:24
Copy link
Copy Markdown
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch by checkbashisms, echo \n always gets me, good to know such a check exists

@jangorecki jangorecki modified the milestones: 1.12.11, 1.12.9 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants