Skip to content

support keep.rownames="id" in as.data.table.xts()#4234

Merged
mattdowle merged 9 commits intomasterfrom
fix4232
Feb 15, 2020
Merged

support keep.rownames="id" in as.data.table.xts()#4234
mattdowle merged 9 commits intomasterfrom
fix4232

Conversation

@shrektan
Copy link
Copy Markdown
Member

@shrektan shrektan commented Feb 5, 2020

Closes #4232

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 5, 2020

Codecov Report

Merging #4234 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4234      +/-   ##
==========================================
+ Coverage   99.61%   99.61%   +<.01%     
==========================================
  Files          72       72              
  Lines       13874    13877       +3     
==========================================
+ Hits        13820    13823       +3     
  Misses         54       54
Impacted Files Coverage Δ
src/freadR.c 100% <100%> (ø) ⬆️
src/frank.c 100% <100%> (ø) ⬆️
R/frank.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c06e12e...3cc28ac. Read the comment docs.

Copy link
Copy Markdown
Member

@jangorecki jangorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but please add tests where keep.rownames is NA_character_ and character(0)

Copy link
Copy Markdown
Member

@jangorecki jangorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattdowle mattdowle added this to the 1.12.9 milestone Feb 14, 2020
@mattdowle mattdowle merged commit f21736a into master Feb 15, 2020
@mattdowle mattdowle deleted the fix4232 branch February 15, 2020 03:33
@jangorecki jangorecki modified the milestones: 1.12.11, 1.12.9 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FR] keep.rownames in as.data.table.xts() supports string

3 participants