Skip to content

need to call as.POSIXct() with tz after "TZ" ENV VAR gets changed #4261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattdowle merged 8 commits into from
May 14, 2021
Merged

need to call as.POSIXct() with tz after "TZ" ENV VAR gets changed #4261

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0933bae
should set tz="UTC" explicitly in test 2137
shrektan Feb 27, 2020
78f6293
Revert "should set tz="UTC" explicitly in test 2137"
shrektan Feb 28, 2020
9ddf2a7
need to call `as.POSIXct()` with tz explicitly otherwise it will fail…
shrektan Feb 28, 2020
0eba2f8
Revert "need to call `as.POSIXct()` with tz explicitly otherwise it w…
shrektan Mar 1, 2020
3841741
should call Sys.unsetenv() when we want to "unset" the env var
shrektan Mar 1, 2020
7e3ae57
Merge branch 'master' into fixtest2137
mattdowle May 13, 2021
2a219d2
revert whitespace
mattdowle May 13, 2021
dcfb0d6
link comment to PRs
mattdowle May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inst/tests/tests.Rraw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16713,7 +16713,7 @@ t0 = as.POSIXct('2019-10-01')
test(2124.1, format(as.ITime(t0)), '00:00:00')
test(2124.2, format(as.IDate(t0)), '2019-10-01')
if (is.na(oldtz)) Sys.unsetenv("TZ") else Sys.setenv(TZ=oldtz)
# careful to unset because TZ="" means UTC whereas unset TZ means local
# careful to unset because TZ="" means UTC whereas unset TZ means local, #4261 and #4464

# trunc.cols in print.data.table, #4074
old_width = options("width" = 40L)
Expand Down