Skip to content

detect new edge case in auto-naming j#4275

Merged
mattdowle merged 4 commits intomasterfrom
autoname-logic
May 14, 2021
Merged

detect new edge case in auto-naming j#4275
mattdowle merged 4 commits intomasterfrom
autoname-logic

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

Closes #4274

I'm not super happy w this "solution", any thoughts for improvement Jan?

Comment thread inst/tests/tests.Rraw Outdated
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2020

Codecov Report

Merging #4275 (1d6a8cc) into master (2d88099) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1d6a8cc differs from pull request most recent head bd7fe54. Consider uploading reports for the commit bd7fe54 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4275   +/-   ##
=======================================
  Coverage   99.46%   99.47%           
=======================================
  Files          75       75           
  Lines       14712    14717    +5     
=======================================
+ Hits        14634    14639    +5     
  Misses         78       78           
Impacted Files Coverage Δ
R/data.table.R 99.94% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d88099...bd7fe54. Read the comment docs.

mattdowle added 2 commits May 13, 2021 19:10
…mber from the PR linked to issue, but it's the issue that we usually want to look at first
@mattdowle mattdowle added this to the 1.14.1 milestone May 14, 2021
@mattdowle mattdowle merged commit 2e68d74 into master May 14, 2021
@mattdowle mattdowle deleted the autoname-logic branch May 14, 2021 01:56
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

auto-names throwing warnings+error with if/else list

3 participants