Conversation
jangorecki
reviewed
Mar 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #4289 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 75 75
Lines 14726 14775 +49
=======================================
+ Hits 14648 14697 +49
Misses 78 78
Continue to review full report at Codecov.
|
mattdowle
requested changes
May 14, 2021
mattdowle
approved these changes
May 14, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4287
Closes #4286
Closes #4277
Two points:
nasupports vectorized input: Thenaargument should be no differences fromyesandnodue to the fact thatTRUE,FALSEandNAare all valid R's logical valuesNAwill be coerced to other types automatically:naargument already performs this behavior. As stated in the 1 point,yesandnoshould behave the same;data.tabledoes this auto-coercion in many other functions