Skip to content

should use the long int 2 to avoid integer overflow#4297

Merged
mattdowle merged 3 commits intomasterfrom
fix4295
Dec 10, 2020
Merged

should use the long int 2 to avoid integer overflow#4297
mattdowle merged 3 commits intomasterfrom
fix4295

Conversation

@shrektan
Copy link
Copy Markdown
Member

@shrektan shrektan commented Mar 11, 2020

Closes #4295

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2020 •
edited
Loading

Codecov Report

Merging #4297 (dd4167f) into master (01943ab) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4297   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          73       73           
  Lines       14589    14589           
=======================================
  Hits        14512    14512           
  Misses         77       77
Impacted Files Coverage Δ
src/gsumm.c 99.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01943ab...dd4167f. Read the comment docs.

@shrektan shrektan mentioned this pull request Mar 12, 2020
Closed
@shrektan shrektan requested a review from mattdowle November 4, 2020 09:06
@shrektan shrektan changed the title should use the long int 2 in case of integer overflow should use the long int 2 to avoid integer overflow Nov 4, 2020
@shrektan shrektan added this to the 1.13.5 milestone Nov 18, 2020
@ColeMiller1 ColeMiller1 mentioned this pull request Dec 4, 2020
Closed
@jangorecki jangorecki linked an issue Dec 4, 2020 that may be closed by this pull request
regression in big grouping #4818
Closed
@jangorecki jangorecki added the High label Dec 4, 2020
@jangorecki jangorecki modified the milestones: 1.13.7, 1.13.5 Dec 9, 2020
@jangorecki
Copy link
Copy Markdown
Member

jangorecki commented Dec 9, 2020

@shrektan could you please include NEWS item as well? mentioning both issues that are being resolved by this fix. Thanks

@jangorecki jangorecki added the GForce issues relating to optimized grouping calculations (GForce) label Dec 9, 2020
@shrektan
Copy link
Copy Markdown
Member Author

shrektan commented Dec 9, 2020

Sure, added.

@mattdowle mattdowle merged commit d405d72 into master Dec 10, 2020
@mattdowle mattdowle deleted the fix4295 branch December 10, 2020 06:10
@jangorecki jangorecki mentioned this pull request Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattdowle mattdowle Awaiting requested review from mattdowle

Assignees

No one assigned

Labels

GForce issues relating to optimized grouping calculations (GForce) High

Projects

None yet

Milestone

1.13.6

Development

Successfully merging this pull request may close these issues.

regression in big grouping Failed to allocate counts or TMP when assigning g in gforce

3 participants

@shrektan @jangorecki @mattdowle