identifying / unifying similar messages for streamlined translation#4299
Merged
identifying / unifying similar messages for streamlined translation#4299
Conversation
MichaelChirico
added
the
translation
Codecov Report
@@ Coverage Diff @@
## master #4299 +/- ##
==========================================
- Coverage 99.53% 99.38% -0.16%
==========================================
Files 76 76
Lines 14467 14490 +23
==========================================
+ Hits 14400 14401 +1
- Misses 67 89 +22
Continue to review full report at Codecov.
|
Member
Author
|
coverage dropped because I added a bunch of newlines before errors in src -- glad to have caught them! might leave them here and address all such cases in a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can see from the diff here that there are lots of messages that are very close in different parts of the source:
Both look quite similar but will create different
msgidin thepotemplate, potentially 1000s of lines apart -- this led to some duplicate efforts already. hoping to at least make the maintenance burden smaller going forward by unifying some similar messages I found.MichaelChirico/potools#1 is intended to help automate this kind of thing eventually, but I'm not really sure how to attack that issue well. Anyway, this PR is progress in that direciton.