Skip to content

set and := no longer warn when LHS is empty#4339

Merged
mattdowle merged 2 commits intomasterfrom
set-0len
Jun 22, 2021
Merged

set and := no longer warn when LHS is empty#4339
mattdowle merged 2 commits intomasterfrom
set-0len

Conversation

@jangorecki
Copy link
Copy Markdown
Member

closes #4086

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@db26698). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 009859e differs from pull request most recent head 1662137. Consider uploading reports for the commit 1662137 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4339   +/-   ##
=========================================
  Coverage          ?   99.61%           
=========================================
  Files             ?       72           
  Lines             ?    13916           
  Branches          ?        0           
=========================================
  Hits              ?    13862           
  Misses            ?       54           
  Partials          ?        0           
Impacted Files Coverage Δ
R/data.table.R 100.00% <ø> (ø)
src/assign.c 100.00% <ø> (ø)
src/between.c 100.00% <ø> (ø)
src/bmerge.c 100.00% <ø> (ø)
src/chmatch.c 100.00% <ø> (ø)
src/cj.c 100.00% <ø> (ø)
src/coalesce.c 100.00% <ø> (ø)
src/dogroups.c 100.00% <ø> (ø)
src/fastmean.c 100.00% <ø> (ø)
src/fcast.c 100.00% <ø> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db26698...1662137. Read the comment docs.

@mattdowle mattdowle added this to the 1.14.1 milestone Jun 22, 2021
@mattdowle mattdowle changed the title set for empty cols does not warn anymore, #4086 set and := no longer warn when LHS is empty Jun 22, 2021
@mattdowle mattdowle merged commit 7ac2120 into master Jun 22, 2021
@mattdowle mattdowle deleted the set-0len branch June 22, 2021 09:00
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

set could allow empty input without warning

2 participants