Skip to content

non-equi join rare segfault bug fix#4389

Merged
arunsrinivasan merged 1 commit intomasterfrom
issue#4388
Apr 20, 2020
Merged

non-equi join rare segfault bug fix#4389
arunsrinivasan merged 1 commit intomasterfrom
issue#4388

Conversation

@arunsrinivasan
Copy link
Copy Markdown
Member

Closes #4388.Test added.

Copy link
Copy Markdown
Member

@jangorecki jangorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2020

Codecov Report

Merging #4389 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4389   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files          72       72           
  Lines       13916    13917    +1     
=======================================
+ Hits        13862    13863    +1     
  Misses         54       54           
Impacted Files Coverage Δ
R/data.table.R 100.00% <100.00%> (ø)
src/nqrecreateindices.c 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b1832...fc35afe. Read the comment docs.

@arunsrinivasan arunsrinivasan merged commit dd7609e into master Apr 20, 2020
@MichaelChirico MichaelChirico deleted the issue#4388 branch April 21, 2020 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non equi joins special rare case bug when used with by=.EACHI

2 participants