Skip to content

fix frank(.SD) for ties.method="random" / na.last=NA#4434

Merged
mattdowle merged 2 commits intomasterfrom
shallow-sd-unlock
Apr 19, 2021
Merged

fix frank(.SD) for ties.method="random" / na.last=NA#4434
mattdowle merged 2 commits intomasterfrom
shallow-sd-unlock

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

Closes #4429

@codecov
Copy link
Copy Markdown

codecov bot commented May 7, 2020

Codecov Report

Merging #4434 (a148794) into master (374e208) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4434   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          73       73           
  Lines       14440    14444    +4     
=======================================
+ Hits        14357    14361    +4     
  Misses         83       83           
Impacted Files Coverage Δ
R/frank.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 374e208...a148794. Read the comment docs.

Copy link
Copy Markdown
Member

@jangorecki jangorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattdowle mattdowle added this to the 1.14.1 milestone Apr 19, 2021
@mattdowle mattdowle merged commit b1d25cd into master Apr 19, 2021
@mattdowle mattdowle deleted the shallow-sd-unlock branch April 19, 2021 04:22
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

frankv with .SD fails when the function calls 'set'

3 participants