Skip to content

keep.rownames=key="str" works for as.data.table.data.frame#4469

Merged
mattdowle merged 4 commits intomasterfrom
as-datatable-rn-key
Aug 18, 2021
Merged

keep.rownames=key="str" works for as.data.table.data.frame#4469
mattdowle merged 4 commits intomasterfrom
as-datatable-rn-key

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

Closes #4468

@mattdowle mattdowle added this to the 1.14.1 milestone Aug 18, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 18, 2021

Codecov Report

Merging #4469 (094579d) into master (ebf0bd0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 094579d differs from pull request most recent head 0bb194a. Consider uploading reports for the commit 0bb194a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4469   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          76       76           
  Lines       14695    14696    +1     
=======================================
+ Hits        14624    14625    +1     
  Misses         71       71           
Impacted Files Coverage Δ
R/as.data.table.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebf0bd0...0bb194a. Read the comment docs.

@mattdowle
Copy link
Copy Markdown
Member

Good - coverage is back in PRs.

@mattdowle mattdowle merged commit 5f0af67 into master Aug 18, 2021
@mattdowle mattdowle deleted the as-datatable-rn-key branch August 18, 2021 09:42
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

as.data.table.data.frame keep.rownames & key

3 participants