Non-equi joins are allow.cartesian = TRUE#4493
Merged
Conversation
jangorecki
reviewed
May 25, 2020
jangorecki
reviewed
May 25, 2020
jangorecki
approved these changes
May 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #4493 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 72 72
Lines 13968 13970 +2
=======================================
+ Hits 13913 13915 +2
Misses 55 55
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #4489
If any non-equi joins are detected
c(">", ">=", "<", "<=", "!="),allow.cartesianis set to TRUE per Arun's suggestion. Debated including warning about thisallow.cartesianchange but for non-equi joins it seems like users should expect a one to many join.