Skip to content

Reworked dt_win_snprintf#4531

Merged
mattdowle merged 3 commits intomasterfrom
dt_win_snsprintf
Jun 7, 2020
Merged

Reworked dt_win_snprintf#4531
mattdowle merged 3 commits intomasterfrom
dt_win_snsprintf

Conversation

@mattdowle
Copy link
Copy Markdown
Member

Closes #4402
As per For #4402 (comment)

@mattdowle mattdowle added this to the 1.12.9 milestone Jun 7, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 7, 2020

Codecov Report

Merging #4531 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4531   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files          73       73           
  Lines       14027    14100   +73     
=======================================
+ Hits        13972    14045   +73     
  Misses         55       55           
Impacted Files Coverage Δ
src/snprintf.c 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3436568...704f113. Read the comment docs.

Copy link
Copy Markdown
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattdowle mattdowle merged commit fc9e445 into master Jun 7, 2020
@mattdowle mattdowle deleted the dt_win_snsprintf branch June 7, 2020 03:18
mattdowle added a commit that referenced this pull request Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rbind unmatched columns crashes R session (Windows, dev version)

2 participants