Skip to content

fix copy not to recurse infinitely on some objects#4620

Merged
mattdowle merged 3 commits intomasterfrom
copy-recursion
Jul 20, 2020
Merged

fix copy not to recurse infinitely on some objects#4620
mattdowle merged 3 commits intomasterfrom
copy-recursion

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

@MichaelChirico MichaelChirico commented Jul 18, 2020

Closes #4616
Closes #4617
Follow-up to #4206

I'm not totally satisfied with this solution, open to suggestions

@MichaelChirico MichaelChirico added this to the 1.12.9 milestone Jul 18, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@bdc6da9). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4620   +/-   ##
=========================================
  Coverage          ?   99.61%           
=========================================
  Files             ?       73           
  Lines             ?    14227           
  Branches          ?        0           
=========================================
  Hits              ?    14172           
  Misses            ?       55           
  Partials          ?        0           
Impacted Files Coverage Δ
R/data.table.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdc6da9...71e4a37. Read the comment docs.

@mattdowle
Copy link
Copy Markdown
Member

mattdowle commented Jul 20, 2020

I can't think of a better solution currently other than moving that loop into C to avoid the dispatch to [[.person method. Since we'll be working on this area again soon, that doesn't seem worth it.
Just needs to be a comment in the code why that class attribute needs to be dropped, will do.

@mattdowle mattdowle merged commit 1cb18e3 into master Jul 20, 2020
@mattdowle mattdowle deleted the copy-recursion branch July 20, 2020 22:41
hongyuanjia pushed a commit to hongyuanjia/data.table that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tableMatrix error on upgrade data.table socialmixr error on upgrade data.table

2 participants