Conversation
Codecov Report
@@ Coverage Diff @@
## master #4631 +/- ##
========================================
Coverage 99.61% 99.61%
========================================
Files 73 73
Lines 14103 14244 +141
========================================
+ Hits 14048 14189 +141
Misses 55 55
Continue to review full report at Codecov.
|
|
|
||
| if (TYPEOF(vec) != STRSXP) error(_("concat: 'vec must be a character vector")); | ||
| static const char *concat(SEXP vec, SEXP idx) { | ||
| if (!isString(vec)) error(_("concat: 'vec must be a character vector")); |
Member
There was a problem hiding this comment.
should be 'vec', i'll file follow-up
Merged
hongyuanjia
pushed a commit
to hongyuanjia/data.table
that referenced
this pull request
Dec 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4628
Confirmed that all parts of test 1036 now pass full strength gctorture(TRUE) with latest R-devel compiled strictly.
concat was marked as a hack anyway so needed attention. If I was forced to guess I'd guess it was that
SETCAR(t, mkString(", "));doesn't protect the result ofmkStringbut I'd be surprised if it doesn't. Initially I protected the result of concat before it was passed on to warning/Rprintf which definitely needed doing, but it wasn't just that (it still failed torture). Not sure what else it could be as I don't see anything else missing protection. The dev cycle time to resolve this one was significant due to the slowness of torture so I just went for the rework approach which needed doing anyway. The new approach for concat is simpler and cleaner, but we need to make sure not to use it twice in the same warning/Rprintf call (comment added).Several of the fmelt tests weren't checking the dynamic parts of their messages; i.e. the result of concat being correct, so I expanded those tests too. I checked that the expanded fmelt tests also pass v1.12.8 to ensure the reworked concat returns the same string as before. concat is only used in warning and verbose messages, and only in fmelt, so the risk of this code rework at this stage in release is limited. Reran rchk just to make sure nothing new introduced, and all fine.