Conversation
Codecov Report
@@ Coverage Diff @@
## master #4692 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 75 75
Lines 14807 14809 +2
=======================================
+ Hits 14729 14731 +2
Misses 78 78
Continue to review full report at Codecov.
|
|
Looks like there was some change to the coverage metrics for C code cc @jangorecki |
|
@jangorecki it looks like all (or most) of the changes are things like The We can either add a |
|
I would start by checking if it is a regression or an enchantment in codecov. |
|
@jangorecki AFAICT no difference in Codecov (not sure how to tell). There may have been a change in I don't see anything particularly noteworthy recently in gcov.c, I don't know what else might be the cause: https://github.com/gcc-mirror/gcc/commits/master/gcc/gcov.c https://gcc.gnu.org/git/?p=gcc.git&a=search&h=HEAD&st=commit&s=gcov |
|
@MichaelChirico seems like this one is ready, great thanks, but just checking as it's still marked WIP |
|
indeed! sorry about that. removed WIP |
| as.IDate.default = function(x, ..., tz = attr(x, "tzone", exact=TRUE)) { | ||
| if (is.null(tz)) tz = "UTC" | ||
| if (is.character(x)) { | ||
| # 4676 mimics for back-compatibility a similar patch applied to as.Date.character in r79119 |
There was a problem hiding this comment.
# 4676 this will not be caught by a regex looking for issue number
There was a problem hiding this comment.
Good spot. Done in df8009d. Since it was just a comment tweak I did that directly without a PR
3 participants
Closes #4676
Actually I wonder if we should branch on the base R capability... for a user on bleeding-edge R-devel, won't they end up running this line of code twice?
Once in
as.IDate.defaultand then once inas.Date.character?In that case, we can branch on:
Or we can store the result of that test in the
.globalenvironment.