Skip to content

fintersect order#4725

Merged
mattdowle merged 6 commits intoRdatatable:masterfrom
ben-schwen:fintersect_order
Jan 5, 2021
Merged

fintersect order#4725
mattdowle merged 6 commits intoRdatatable:masterfrom
ben-schwen:fintersect_order

Conversation

@ben-schwen
Copy link
Copy Markdown
Member

Closes #4716 fintersect now preserves order of 1st argument like intersect does instead of preservering order of 2nd argument.

Comment thread R/setops.R
@mattdowle mattdowle added this to the 1.13.7 milestone Jan 5, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 5, 2021

Codecov Report

Merging #4725 (17e0916) into master (dae9652) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4725   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          73       73           
  Lines       14559    14559           
=======================================
  Hits        14482    14482           
  Misses         77       77           
Impacted Files Coverage Δ
R/setops.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae9652...17e0916. Read the comment docs.

@mattdowle
Copy link
Copy Markdown
Member

mattdowle commented Jan 5, 2021

Thanks, Ben and welcome! I've added your name to the contributors list in DESCRIPTION so you're now a copyright holder of data.table. I've also invited you to be a project member so that in future you can create branches in the main project. That makes it a bit easier to work on each others branches if they are in the main project rather than a fork. To accept the invitation there should now be a button in your GitHub profile or projects page that you have to click.

@mattdowle mattdowle changed the title Fintersect order fintersect order Jan 5, 2021
@mattdowle mattdowle merged commit f395b9e into Rdatatable:master Jan 5, 2021
@mattdowle mattdowle modified the milestones: 1.13.7, 1.14.0 Feb 20, 2021
@ben-schwen ben-schwen deleted the fintersect_order branch October 1, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fintersect() does not preserve order

3 participants