add na.rm argument to first/last and gfirst/glast#4730
Closed
ben-schwen wants to merge 9 commits intoRdatatable:masterfrom
Closed
add na.rm argument to first/last and gfirst/glast#4730ben-schwen wants to merge 9 commits intoRdatatable:masterfrom
ben-schwen wants to merge 9 commits intoRdatatable:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4730 +/- ##
==========================================
- Coverage 99.44% 99.18% -0.26%
==========================================
Files 73 73
Lines 14539 14649 +110
==========================================
+ Hits 14458 14530 +72
- Misses 81 119 +38
Continue to review full report at Codecov.
|
jangorecki
reviewed
Oct 15, 2020
jangorecki
reviewed
Oct 15, 2020
Member
jangorecki
left a comment
There was a problem hiding this comment.
last comment about styling, other than that it looks good
Member
Author
|
Closing here since incompatible with merged #5109 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4446
Closes #4239
Adds an
na.rmargument with defaultna.rm=FALSEtofirst()/last()andgfirst()/glast().Here should be noted that
gfirst()andglast()return the first resp. last non NA value if such a value exists. If such a value does not existgfirst()/glast()still return NA similar togmedian(),gvar()andgsd().